Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(NODE-6173): add rangeV2 feature flag toggle to Node.js bindings #6

Merged
merged 1 commit into from
May 23, 2024

Conversation

nbbeeken
Copy link
Collaborator

@nbbeeken nbbeeken commented May 23, 2024

Description

What is changing?

See the ticket for motivation/why it would be convenient to have this earlier than the 'main' range V2 work 🙂

Is there new documentation needed for these changes?

No

What is the motivation for this change?

Testing

Porting change from: mongodb/libmongocrypt#809

Release Highlight

Adds an internal flag to enable rangeV2

A new option rangeV2 can be passed to the MongoCrypt constructor to enable the new protocol. It is marked expiremental because it will likely be removed in a future release, this is for testing only.

Double check the following

  • Ran npm run check:lint script
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@baileympearson baileympearson merged commit e35bd59 into main May 23, 2024
3 checks passed
@baileympearson baileympearson deleted the NODE-6173-rangeV2Flag branch May 23, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants